Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pirut https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226298 katzj@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|katzj@xxxxxxxxxx |jima@xxxxxxxxxxxxxx Flag|fedora-review- |fedora-review? ------- Additional Comments From katzj@xxxxxxxxxx 2007-02-12 16:45 EST ------- (In reply to comment #2) > 1. Ha ha ha > No upstream site, no MD5SUM to authenticate against, no place to check > we have the latest version. We should probably do something about that. > :-) Someday maybe... right now, no one else has even expressed interest in using it, so it's not worth the overhead of having a site, etc. The authoritative source is the src.rpm > 2. The recommended BuildRoot is: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) jbowes fixed this up for 1.2.11 > 3. rpmlint says: [snip] > These are a bit concerning, but based on our discussion on IRC, I have > to agree that they're probably a necessary evil. All of these packages > provided, at one time or another, the same functionality that pirut > does. They're all long gone from Fedora, probably never to come back. > I'd suggest adding Provides for the Obsoleted packages, and perhaps > versioning the Obsoletes, but I honestly can't say what the long-term > side effects to that might be. Ergo, I imagine we need to just go with > what we've got. (Besides, it's already in Core.) Yeah, necessary evil of having legacy. The obsoletes are for the upgrade path only, not for people wanting to require a specific type of functionality. > 4. I'm a bit concerned about pirut's use of /etc/xdg/autostart/ -- it's > owned by gnome-session, but I'm not seeing any sort of dependency on > gnome-session. This might be a problem. jbowes fixed this up too > 5. Open bugs. Holy carp! 62 open bugs! I expected it was over 100 at this point ;-) Big triage to come hopefully the end of this week. Trying to get a few other things in shape prior to the feature freeze, though, so it remains to be seen. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review