Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jrexx-1.1.1-3jpp - Automaton based regluar expression API for Java https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227074 klee@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klee@xxxxxxxxxx ------- Additional Comments From klee@xxxxxxxxxx 2007-02-12 16:43 EST ------- Review comments: * incorrect buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * license text not included in package and marked with %doc * rpmlint on <this package>.srpm gives some output W: jrexx non-standard-group Development/Libraries/Java E: jrexx unknown-key GPG#c431416d W: jrexx setup-not-quiet * changelog should be in one of these formats: * Fri Jun 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> - 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> - 0.6-4 - And fix the link syntax. * Vendor tag should not be used * some lines are > 80 characters * does not use macros appropriately and consistently - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review