Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnu.trove-1.0.2-4jpp - High performance collections for Java https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227058 jjohnstn@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review- ------- Additional Comments From jjohnstn@xxxxxxxxxx 2007-02-12 15:01 EST ------- MUST: X remove %define short-name and simply use trove in %Name X release should be of form: Xjpp.Y%{?dist} X no explanation of how source0 generated or where fetched from X correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) X rpmlint on <this package>.srpm gives no output [jjohnstn@vermillion Desktop]$ rpmlint gnu-trove-1.0.2-5jpp.src.rpm W: gnu-trove non-standard-group Development/Libraries/Java E: gnu-trove unknown-key GPG#c431416d W: gnu-trove unversioned-explicit-provides gnu.trove W: gnu-trove unversioned-explicit-obsoletes gnu.trove W: gnu-trove unversioned-explicit-provides gnu.trove-javadoc W: gnu-trove unversioned-explicit-obsoletes gnu.trove-javadoc W: gnu-trove mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 52) X Vendor tag should not be used X make sure lines are <= 80 characters * verify the final provides and requires of the binary RPMs * run rpmlint on the binary RPMs [jjohnstn@vermillion noarch]$ rpmlint gnu-trove-1.0.2-5jpp.noarch.rpm W: gnu-trove non-standard-group Development/Libraries/Java [jjohnstn@vermillion noarch]$ rpmlint gnu-trove-javadoc-1.0.2-5jpp.noarch.rpm W: gnu-trove-javadoc non-standard-group Development/Documentation W: gnu-trove-javadoc dangerous-command-in-%post rm W: gnu-trove-javadoc dangerous-command-in-%postun rm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review