Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: tcl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226479 ------- Additional Comments From wart@xxxxxxxxxx 2007-02-12 14:51 EST ------- (In reply to comment #2) > Review will be needed for tcl8.4. Ok, then I'll start a full review based on the current state of CVS. > Source tk is needed for generating html. I checked upstream, and they publish the html pages: http://superb-east.dl.sourceforge.net/sourceforge/tcl/tcl8.4.13-html.tar.gz This will let you separate out the -html subpackage into a standalone package and drop the included tk source tarball. The -html subpackage can also be made "BuildArch: noarch" since it contains only html and a few images. > BuildRequires are needed (sed is in configure). Separating the html documentation into a separate package removes the need for 'BuildRequires: man'. sed is in the minimal build environment, and is explicitly disallowed by the packaging guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30 > What do you mean by redundant version? In the main package you specify: URL: http://tcl.sourceforge.net/ And again in the -devel (and other) subpackage, you specify the url tag again. If you leave off the URL: tag in the -devel subpackage, then it will inherit the value from the main package. The same is true for the Version: tag; it's not necessary to specify it again in the subpackage. > Links for backward compatibily stay in tcl 8.4. I'll fix it for new version. Ok, but it would still be nice to address the second component of bug #227200, adding %{_libdir}/tcl%{majorver} to auto_path. This would let us proceed with updating the extensions in preparation for bug #226893. But this is really an orthogonal issue to the merge review, so I won't block the review just for this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review