[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=848551

--- Comment #9 from Kai Engert (:kaie) <kengert@xxxxxxxxxx> ---
> Wrong FSF addresses and missing man pages, no real problems.

I've mailed the upstream maintainer and asked to get the FSF license headers
updated in a future release.


> Add the following line to %files:
> %doc AUTHORS COPYING NEWS README TODO

I believe it's not as simple as you think,
because the upstream installation scripts don't install these files into the
area that will be used as the base for packaging.

I added copy commands to %install that copy those files to %{_docdir}/%{name}/
and added appropriate entries to %files


> Change the license to GPLv3+ according to some file headers in the source
> tarball.

Ok.


> Don't forget to track your changes in the %changelog, as already mentioned.

ok


Updated:

Spec URL: http://kuix.de/fedora/ppm/prepaid-manager-applet.spec
SRPM URL:
http://kuix.de/fedora/ppm/prepaid-manager-applet-0.0.3.1-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]