[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=848551

--- Comment #8 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4416747

$ rpmlint -i -v *
prepaid-manager-applet.src: I: checking
prepaid-manager-applet.src: I: checking-url
https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds)
prepaid-manager-applet.src: I: checking-url
http://honk.sigxcpu.org/projects/ppm/tarballs/prepaid-manager-applet-0.0.3.1.tar.xz
(timeout 10 seconds)
prepaid-manager-applet.noarch: I: checking
prepaid-manager-applet.noarch: I: checking-url
https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds)
prepaid-manager-applet.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/accountdb.py
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/provider.py
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/providerdb.py
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/prepaid-manager-applet.py
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/modemproxy.py
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

prepaid-manager-applet.noarch: W: no-manual-page-for-binary
prepaid-manager-applet
Each executable in standard binary directories should have a man page.

2 packages and 0 specfiles checked; 5 errors, 2 warnings.


Wrong FSF addresses and missing man pages, no real problems.


But still some recognizable issues:

Add the following line to %files:
%doc AUTHORS COPYING NEWS README TODO

Change the license to GPLv3+ according to some file headers in the source
tarball.

Don't forget to track your changes in the %changelog, as already mentioned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]