[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=807479

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #10 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4425164

$ rpmlint -i -v *spacewalk-setup-jabberd.src: I: checking
spacewalk-setup-jabberd.src: I: checking-url https://fedorahosted.org/spacewalk
(timeout 10 seconds)
spacewalk-setup-jabberd.src: I: checking-url
https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.5.tar.gz
(timeout 10 seconds)
spacewalk-setup-jabberd.noarch: I: checking
spacewalk-setup-jabberd.noarch: E: explicit-lib-dependency libxslt
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

spacewalk-setup-jabberd.noarch: I: checking-url
https://fedorahosted.org/spacewalk (timeout 10 seconds)
spacewalk-setup-jabberd.spec: I: checking-url
https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.5.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

As already discussed, the libxslt requirement is OK.

%{_sysconfdir}/pki/spacewalk
has to be
%config(noreplace) %{_sysconfdir}/pki/spacewalk

No further issues. Once you've fixed the file list, I will do a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]