[Bug 847811] Review Request: libee - An event expression library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847811

Milan Bartos <mbartos@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mbartos@xxxxxxxxxx

--- Comment #2 from Milan Bartos <mbartos@xxxxxxxxxx> ---
Hi, this is just an informational review.

1. use macros and variables consistently
2. %clean is not necessary
3. i'm not sure about %{_sbindir}/libee-convert, it could go in separate -utils
package

Regards,
Milan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]