https://bugzilla.redhat.com/show_bug.cgi?id=830387 --- Comment #5 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- (In reply to comment #4) > (In reply to comment #2) > > In the %build phase you're adding -D_FILE_OFFSET_BITS=64 to the CFLAGS. Is > > this really needed for MinGW builds? IIRC this is a Linux-specific hack. > > Yes, because in the MinGW headers there are specific checks for > _FILE_OFFSET_BITS to enable 64-bit sized variables for file handling. This > enables large file (>4GB) support. If I am mistaken about this I can remove > them, but it looks like they are needed to me. Okay, good enough for me In that case, could replace $MINGW32_CFLAGS and $MINGW64_CFLAGS with %{mingw32_cflags} and %{mingw64_cflags} so that the regular MinGW CFLAGS get applied properly? By default the environment flags MINGW32_CFLAGS and MINGW64_CFLAGS aren't set automatically -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review