[Bug 830387] Review Request: mingw-xz - MinGW package for xz compression utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=830387

--- Comment #4 from Michael Cronenworth <mike@xxxxxxxxxx> ---
(In reply to comment #2)
> In the %build phase you're adding -D_FILE_OFFSET_BITS=64 to the CFLAGS. Is
> this really needed for MinGW builds? IIRC this is a Linux-specific hack.

Yes, because in the MinGW headers there are specific checks for
_FILE_OFFSET_BITS to enable 64-bit sized variables for file handling. This
enables large file (>4GB) support. If I am mistaken about this I can remove
them, but it looks like they are needed to me.

> rpmlint also gives some minor complaints about mixed-use-of-spaces-and-tabs.
> Could you fix that one as well?

Not sure how that happened. Fixed and updated to 5.1.2.

New spec: http://michael.cronenworth.com/RPMS/mingw-xz.spec
New SRPM:
http://michael.cronenworth.com/RPMS/mingw-xz-5.1.2-1alpha.fc17.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4423754

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]