https://bugzilla.redhat.com/show_bug.cgi?id=851279 --- Comment #2 from Andy Grimm <agrimm@xxxxxxxxx> --- (In reply to comment #1) > This spec is quite complex. Yes it is. > I noticed a few issues : > - %{_libdir}/eucalyptus/ is unowned Oops... I'll certainly correct that > - Source11: eucalyptus-3.1.0-generated.tgz > there is no comment on where and how this was generated or downloaded from Good point, I should be more specific about exactly how to reproduce it. My hope is that we'll get a more compatible version of axis2 into Fedora so that I can get rid of this. > - the whole stuff like : > %global euca_libvirt libvirt > > do not make the spec very readable, IMHO. It would be easier to inline > directly These variables were pulled in from upstream's official rpm packaging, which suport several different distros. I can remove the ones related to file / package names. I'd like to keep the ones which refer to paths which are specified throughout the SPEC, though. > - some patch do not have a mention of being sent upstream ( 14, 15, 16 among > others ), any reasons ? I just haven't filed issues for them yet. In the case of 15, it's closely related to #13, and should just be grouped under the same comment > - some packages would be installed without license file, like > eucalyptus-axis2-clients or python%{?pybasever}-eucadmin Those are BSD, and upstream does not package a copy of that license file. > - by the way, if nothing define %ybasever, what is the use ? That was related to RHEL 6 packaging, and isn't really necessary for this version of the package. I Can remove those. > - the various %post are puzzling, why does it reload udev, why does -walrus > restart eucalyptus-cloud.service ? I'm not sure about the udev reload; that came from upstream packaging. walrus is a component of the eucalyptus-cloud service. When that or eucalyptus-sc changes, eucalyptus-cloud must be restarted. Thank you for the comments. I'll work on some changes an post a new spec. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review