https://bugzilla.redhat.com/show_bug.cgi?id=851279 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- This spec is quite complex. I noticed a few issues : - %{_libdir}/eucalyptus/ is unowned - Source11: eucalyptus-3.1.0-generated.tgz there is no comment on where and how this was generated or downloaded from - the whole stuff like : %global euca_libvirt libvirt do not make the spec very readable, IMHO. It would be easier to inline directly - some patch do not have a mention of being sent upstream ( 14, 15, 16 among others ), any reasons ? - some packages would be installed without license file, like eucalyptus-axis2-clients or python%{?pybasever}-eucadmin - by the way, if nothing define %ybasever, what is the use ? - the various %post are puzzling, why does it reload udev, why does -walrus restart eucalyptus-cloud.service ? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review