https://bugzilla.redhat.com/show_bug.cgi?id=847901 --- Comment #5 from Steven Roberts <strobert@xxxxxxxxxx> --- 1. dropped the prefix specification. This spec file was created a while ago and back then was cut from template that used relocatable packages. It was back in the days before LVM2, yum and was best practices at the time. I read the Fedora guidelines on it and makes sense to drop it in this day and age. 2. I had thought about adding it (I've seen it as a user for years now) but I thought someplace I read that you should only do so when needed. I re-read that disttag page and sounds like it is recommended. so I've added it. 3. I had some weird compiler errors when using %make_install instead of %makeinstall. 4. Yup, that is the upstream naming. Added a comment in the spec file. it is like openssh and 4.3p2 :). I'm going to poke at makeinstall a bit more and I'll post back in here on what I'm able to come up with. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review