https://bugzilla.redhat.com/show_bug.cgi?id=847901 --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> --- Some general comments/suggestions/changes before the review: 1. Please don't define %{prefix} 2. (not a blocker, but IMHO a good idea) consider using the dist tag on your version http://fedoraproject.org/wiki/Packaging:DistTag 3. If you can avoid using %makeinstall that would be good. See: http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used 4. I'm assuming upstream releases packages in a post release a, b, c, d, way right? If so, then your version is fine. If not you may want to look at: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages and add a note/comment in the spec about what upstream does here. ;) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review