https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #3 from Kai Engert (:kaie) <kengert@xxxxxxxxxx> --- > You have to replace all occurences of pygobject2 with pygobject3 in > BuildRequires and Requires. done > Moreover, you can drop the following from BuildRequires: > gettext: needed by intltool ok > python2-devel: obsolete, has to be python3-devel actually, but it is not > needed because the Python build stack (setup.py etc.) is not used here, the > package uses autotools removed > glib2-devel: needed by Gtk anyway, the v2 is obsolete for the newest sources removed > There are a lot of entries in Requires. You should build your package > without them and check what is picked up automatically. Then add those which > are not found by rpm. We had: Requires: mobile-broadband-provider-info ModemManager gtk3 Requires: dbus-python pygobject3 gtk3 I'm surprised you call that "a lot". I removed the duplicate gtk3. Why is it a problem to list requirements explicity? I'll try to run the try-and-error experiments you've asked for, if they're not requiring too much time. > The initial cleaning of %{buildroot} in the %install section and the > %defattr line in %files are obsolete. Please drop them removed > Some files are installed in %{_datadir}/icons/hicolor/, you have to add the > following scripts to update the icon cache: added > To install the desktop file correctly, you have to add desktop-file-utils to > BuildRequires. It was already there. > And last but not least: Please don't forget to log your changes in the > Changelog! will do -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review