[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=848551

--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build fails for f17 and f18:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4400046
http://koji.fedoraproject.org/koji/taskinfo?taskID=4400294

>From build.log:

> configure: error: Package requirements (glib-2.0 >= 2.25.6
>                         gtk+-3.0 >= 3.0.0
>                         pygobject-3.0 >= 3.0) were not met:
> No package 'pygobject-3.0' found

You have to replace all occurences of pygobject2 with pygobject3 in
BuildRequires and Requires. Moreover, you can drop the following from
BuildRequires:

gettext: needed by intltool

python2-devel: obsolete, has to be python3-devel actually, but it is not needed
because the Python build stack (setup.py etc.) is not used here, the package
uses autotools

glib2-devel: needed by Gtk anyway, the v2 is obsolete for the newest sources


There are a lot of entries in Requires. You should build your package without
them and check what is picked up automatically. Then add those which are not
found by rpm.

The initial cleaning of %{buildroot} in the %install section and the %defattr
line in %files are obsolete. Please drop them unless you would want to provide
your package for EPEL 5 (which is impossible due to unresolvable dependencies).


Some files are installed in %{_datadir}/icons/hicolor/, you have to add the
following scripts to update the icon cache:

%post
touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :

%postun
if [ $1 -eq 0 ] ; then
    touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :


To install the desktop file correctly, you have to add desktop-file-utils to
BuildRequires.

And last but not least: Please don't forget to log your changes in the
Changelog!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]