[Bug 839395] Review Request: rubygem-openshift-origin-controller - Rails engine for the OpenShift Broker API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=839395

--- Comment #19 from Brenton Leanhardt <bleanhar@xxxxxxxxxx> ---
I'm not sure I completely understand your stance on patch1.  Are you saying
that no changes to the gemspec are needed?  Currently the Gemfile pulls all gem
dependencies from the gemspec.  If the gemspec isn't patched to label the test
dependencies as development only I believe the library will fail to load.

I'm fine with dropping patch0 though.  It was a recommendation by another
reviewer and I've already resolved the issue upstream.

I am curious about the dangers of using the upstream gemspec.  If there is any
documentation on this I would be happy to read through it!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]