https://bugzilla.redhat.com/show_bug.cgi?id=839395 --- Comment #18 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #16) > Regarding %patch1, that was another mistake. I had incorrectly ported a > change that was recommended in http://fedoraproject.org/wiki/Packaging:Ruby. > There the following is used in prep: > > gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec > > I believe that command creates whitespace differences that causes gemspec > patches to fail (if they were was created against the original source). > That meant if I needed to patch the gemspec I had to patch it after that > command. > > If that line isn't absolutely necessary I would like to avoid it. Currently > I believe (fixed) prep section is much more readable: > > gem unpack %{SOURCE0} > %setup -q -D -T -n %{gem_name}-%{version} > %patch0 -p1 > %patch1 -p1 You took dangerous path. Please don't recreate the gem using upstream .gemspec file and use the one created by "gem spec" command. If you compare these two, you'll be surprised how different they look. Moreover, looking into the patches: * I would drop the Patch0 entirely, since I don't see any real benefit to carry it along. * I would drop the Patch1, since it changes (1) development dependencies (2) they are not satisfied in Fedora anyway. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review