[Bug 847457] Review Request: rubygem-transaction-simple - Simple object transaction support for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847457

--- Comment #5 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
>  - You remove one file in %build section while the other in %install, is it
>    intentional?

No, it was completly random :)
Moved to %install

> I would put %exclude %{gem_instdir}.* into %files section instead
I prefer that rm (for no obvious reason).

>  btw you should use the %{gem_instdir} macro in the rm in %build section.
fixed

> Seems that the homepage URL was changed to
indeed, fixed

> You should probably remove the chmods a+x in %install section and use
>    chmod a-x test/test_broken_graph.rb
Ah, they change it from last version. Fixed.

Thanks for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]