https://bugzilla.redhat.com/show_bug.cgi?id=847457 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #3) > > Is there any particular reason why not package the most recent version? > Yes. 1.4.0.2 depends on hoe ~> 3.0 which is not in EPEL and F16. My plan is > to later upgrade to 1.4.0.2 in rawhide. > > > Do not depend on rubygem(hoe) > indeed it is used for creating tar.gz. And it builds without it. > Removing. Hmm... that may solve previous item. :D > > * Leave the History.txt Install.txt Licence.txt Readme.txt Manifest.txt on > > original place > I do not agree with you. Roger * dot files - You remove one file in %build section while the other in %install, is it intentional? - I would put %exclude %{gem_instdir}.* into %files section instead - btw you should use the %{gem_instdir} macro in the rm in %build section. * URL - Seems that the homepage URL was changed to http://trans-simple.rubyforge.org/ * rpmlint: - You should probably remove the chmods a+x in %install section and use chmod a-x test/test_broken_graph.rb rubygem-transaction-simple-doc.noarch: E: script-without-shebang /usr/share/gems/gems/transaction-simple-1.4.0.2/test/test_transaction_simple_group.rb rubygem-transaction-simple-doc.noarch: E: script-without-shebang /usr/share/gems/gems/transaction-simple-1.4.0.2/test/test_transaction_simple.rb rubygem-transaction-simple-doc.noarch: E: script-without-shebang /usr/share/gems/gems/transaction-simple-1.4.0.2/Rakefile rubygem-transaction-simple-doc.noarch: E: script-without-shebang /usr/share/gems/gems/transaction-simple-1.4.0.2/test/test_broken_graph.rb Otherwise the package looks good, so I APPROVE it, but please consider to fix the first two nits and definitely fix the rpmlint errors prior importing into SCM. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review