https://bugzilla.redhat.com/show_bug.cgi?id=845805 Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- (In reply to comment #4) > > - Is there any benefit of moving the various doc files in %install section? The > > optimal solution, I think, is to leave them in %{gem_instdir} and mark them as > > %doc there. > > It is good habbit on every other package but rubygems. Location is not > mandated by guidelines. I already opened discussion about it on packaging > mailing lists. > I don't see any such discussion, would you care to post a link here? > > Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3, > > LICENSE) in the main package and move the others to the -doc subpackage. > > So you mean just copy README.rdoc, to -doc package? ok. > I also meant CHANGELOG :) Please move that before importing to dist-git, too. > > It is customary to exclude cached gem in the RPM packaged gems, please do so. > > done > > > %{gem_docdir} should be marked as %doc. > > done > > Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec > SRPM URL: > http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-3.fc17. > src.rpm The package looks good now. Please move the CHANGELOG file to -doc subpackage, as mentioned above, before importing to dist-git. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review