[Bug 825494] Review Request: cliquer - Find cliques in arbitrary weighted graphs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825494

--- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> ---
Everything is fixed except the nonstandard executable permissions.  Also, there
are some explicit uses of the version number.  I suggest fixing both like this:

--- cliquer.spec.orig    2012-08-15 09:12:35.402848523 -0600
+++ cliquer.spec    2012-08-15 10:13:20.123509731 -0600
@@ -72,9 +72,9 @@
 gcc ${RPM_OPT_FLAGS} -fPIC -c cliquer.c
 gcc ${RPM_OPT_FLAGS} -fPIC -c graph.c
 gcc ${RPM_OPT_FLAGS} -fPIC -c reorder.c
-gcc ${RPM_OPT_FLAGS} -fPIC -shared -o libcliquer.so.1.21 \
+gcc ${RPM_OPT_FLAGS} -fPIC -shared -o libcliquer.so.%{version} \
   -Wl,-soname=libcliquer.so.1 cl.o cliquer.o graph.o reorder.o
-ln -s libcliquer.so.1.21 libcliquer.so.1
+ln -s libcliquer.so.%{version} libcliquer.so.1
 ln -s libcliquer.so.1 libcliquer.so

 # Now build the binary
@@ -85,10 +85,11 @@
 # Install the library
 mkdir -p $RPM_BUILD_ROOT%{_libdir}
 cp -pP libcliquer.so* $RPM_BUILD_ROOT%{_libdir}
+chmod 0755 $RPM_BUILD_ROOT%{_libdir}/libcliquer.so.%{version}

 # Install the binary
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
-cp -p cliquer $RPM_BUILD_ROOT%{_bindir}/cliquer
+install -m 0755 -p cliquer $RPM_BUILD_ROOT%{_bindir}/cliquer

 # Install the header file
 mkdir -p $RPM_BUILD_ROOT%{_includedir}/cliquer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]