https://bugzilla.redhat.com/show_bug.cgi?id=839064 --- Comment #33 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * It is good habit to bump release each version you submit for a review. - This makes easier to track changes you have made. - You could use rpmdev-bumpspec tool to bump the release. * Now, I am a bit confused. The latest .spec you provided is different then the .spec in your SRPM and moreover, the changelog does not corresponds with Release specified in the header. So what is the most recent version? - I am going to assume that the independent .spec file is the most recent one. * Keep the LICENSE and COPYRIGHT file on their original locations. - I.e. reference them as a %{gem_instdir}/LICENSE and %{gem_instdir}/COPYRIGHT in the %files section. (In reply to comment #27) > > * Macros for gem packaging > > I added a comment to Bug 788001. I would appreciate if you could follow the example I provided to you and use new Fedora macros by default. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review