https://bugzilla.redhat.com/show_bug.cgi?id=839064 --- Comment #32 from Brenton Leanhardt <bleanhar@xxxxxxxxxx> --- (In reply to comment #31) > Brenton, > > Those look like good reviews, but I'd recommend the following workflow. > > Report problems you have identified by manually inspecting the tarball and > specfile. > > When developer has fixed all the problems you have found, provide a complete > fedora review. Your fedora reviews are missing results (because the > automated tool can't check them yet/ever). In this case, you should > manually determine if the package passes muster by including a X, or -, or !. > > Can you go back to those last two reviews and do that? > > After that is done correctly, I'll formally review your package. > > Regards > -steve I've manually checked all items fedora-review could not automate for these packages: This one has licensing issues: https://bugzilla.redhat.com/show_bug.cgi?id=848043 I would approve this package: https://bugzilla.redhat.com/show_bug.cgi?id=847504 My suspicion is that the license issue will take a while to resolve with upstream. Technically in comment #25 you said I would only need to do this for one package, right? :) We're a little desperate at this point to get all of the OpenShift Origin packages in for F18 at this point. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review