https://bugzilla.redhat.com/show_bug.cgi?id=847504 --- Comment #13 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #12) > I prefere to have LICENSE and README in /usr/share/doc/* as they are not > need for runtime and all other package put these files in /usr/share/doc/*. > I know it one more line in %install, but I can live it. If it is blocker, I > will remove it. Well, there is no other gem to my knowledge, which would move the files outside of their original locations, so if your package should be exceptional, so be it. It is up to you. > > .gemspec to -doc - done > > init.rb to -doc - I hesitate. > "init.rb: Runs everytime the Rails app is started. Useful for mixing-in a > helper module so all your views can use it." > I think this is runtime thing. Well, init.rb runs when you are using it as a Rails plugin, i.e. you will take the original code and place it into your applications vendor directory. If you are using the code as a gem, it has no meaning IMO. It even cannot get on load path, so there is no way how to use it. Moreover, if it would be possible to place it in the load path, it would be dangerous, because there would be more than one init.rb file and you could never know which one will be used. But since it does not harm anybody or anything, I'll keep it up to you. > ad test suite. > I added your code there, but commented for now. It fails misserably with 13 > failures and lots deprecated warning on F17. I may later test it on rawhide. > But I would prefer to skip it for now. Testing it right now in F17 [1], I got only one error, pretty same as in Rawhide. So I would suggest to enable the test suite and consult the error with upstream. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4391927 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review