[Bug 847504] Review Request: rubygem-scoped_search - Easily search you ActiveRecord models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847504

--- Comment #12 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
Spec URL:
http://miroslav.suchy.cz/fedora/rubygem-scoped_search/rubygem-scoped_search.spec
SRPM URL:
http://miroslav.suchy.cz/fedora/rubygem-scoped_search/rubygem-scoped_search-2.3.7-10.fc17.src.rpm

I fixed that SOURCE0

I moved deletion of dot files to %install section

I excluded that gem for now, I started discussion about it on ruby-sig mailing
list

I prefere to have LICENSE and README in /usr/share/doc/* as they are not need
for runtime and all other package put these files in /usr/share/doc/*.
I know it one more line in %install, but I can live it. If it is blocker, I
will remove it.

.gemspec to -doc  - done

init.rb to -doc - I hesitate. 
"init.rb: Runs everytime the Rails app is started. Useful for mixing-in a
helper module so all your views can use it."
I think this is runtime thing.

ad test suite.
I added your code there, but commented for now. It fails misserably with 13
failures and lots deprecated warning on F17. I may later test it on rawhide.
But I would prefer to skip it for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]