[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
- Is there any benefit of moving the various doc files in %install section? The
optimal solution, I think, is to leave them in %{gem_instdir} and mark them as
%doc there.
- Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3,
LICENSE) in the main package and move the others to the -doc subpackage.
- It is customary to exclude cached gem in the RPM packaged gems, please do so.
- %{gem_docdir} should be marked as %doc.

Otherwise the package looks good, so please fix these and post updated
SPEC/SRPM so I can take one more look and approve it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]