https://bugzilla.redhat.com/show_bug.cgi?id=848144 --- Comment #2 from MERCIER Jonathan <bioinfornatics@xxxxxxxxx> --- (In reply to comment #1) > Release: 1.%{alphatag}%{?dist}.3 > > The .3 should not be here, and I'm unsure about the 1. prefix (looking at > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages ) I agree .3 is an artifact > Why this specific revision (9612bcd79130)? Is it recommended by upstream? > Used by other distros? or just random? Not recommended by upstream i taken the last revision from mercurial repo. I will work with upstream. As achlinux has already SDL2 into their repository they are no reason to do same. In more SDL do not override SDL 1.2 . > The BuildRequires: geany and generation of the geany tags are unneeded and > don't belong there imo. Ok it was to help developer. > chmod 644 $(find src \( -name "*.c" -or -name "*.h" \) ) > Do you get any issues if you don't change the file permissions? If yes, this > should be mentioned in the comment above, if not, I think you can tell rpm > to adjust the file permissions for you in %file debuginfo take this sources files then %attr is not useful here spec: http://bioinfornatics.fedorapeople.org/SDL2.spec srpms: http://bioinfornatics.fedorapeople.org/SDL2-2-2.20120812hg9612bcd79130.fc17.src.rpm thanks -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review