https://bugzilla.redhat.com/show_bug.cgi?id=848144 Christophe Fergeau <cfergeau@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cfergeau@xxxxxxxxxx --- Comment #1 from Christophe Fergeau <cfergeau@xxxxxxxxxx> --- Release: 1.%{alphatag}%{?dist}.3 The .3 should not be here, and I'm unsure about the 1. prefix (looking at http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages ) Why this specific revision (9612bcd79130)? Is it recommended by upstream? Used by other distros? or just random? The BuildRequires: geany and generation of the geany tags are unneeded and don't belong there imo. chmod 644 $(find src \( -name "*.c" -or -name "*.h" \) ) Do you get any issues if you don't change the file permissions? If yes, this should be mentioned in the comment above, if not, I think you can tell rpm to adjust the file permissions for you in %file -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review