[Bug 839064] Review Request: rubygem-openshift-origin-common - OpenShift Origin library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=839064

--- Comment #27 from Brenton Leanhardt <bleanhar@xxxxxxxxxx> ---
(In reply to comment #26)

> * rubygems.org as a source

We'll consider publishing to rubygems.org however this is not the way we would
recommend users install the serverside components of OpenShift Origin at this
point.  We'd like to avoid to case where we end up having to support 'gem
install' versions of Origin before we're ready.

> * Macros for gem packaging

I added a comment to Bug 788001.

> 
> * Documentation in -doc subpackage

We'll be happy to create separate -doc subpackages in the future.  Right now we
think it would be a distraction to making Origin available to the community so
we don't plan to do it for Fedora 18.

> 
> * mongo dependencies

The unneeded require was removed and the gemspec was patch.  The fix has been
submitted upstream.

> 
> 
> * Url does not correspondent with the gems one

This was fixed upstream as well for all Origin rubygems.  Great catch.

> 
> BTW I am not sure why the line 'require
> "stickshift-common/exceptions/ss_exception"' is duplicated in
> lib/stickshift-common.rb, but this is upstream issue.

That's almost certainly a copy/paste error.  I'll fix that upstream!

Here are the latest artifacts:

SRPM:
http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-common/201208101436/rubygem-openshift-origin-common-0.13.3-4.fc16.src.rpm

Spec:
http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-common/201208101436/rubygem-openshift-origin-common.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]