https://bugzilla.redhat.com/show_bug.cgi?id=839064 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #26 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Hi, I have several comments regarding this package and they might be applied to other openshift packages as well * rubygems.org as a source - I am wondering why don't you use rubygems.org as every Rubyist would expect to be standard source of every gem. This is just for curiosity and to prevent possible (although in this case unlikely) name collision * Macros for gem packaging - It was already mentioned by Troy, that rubygems-devel package provides some useful macros for gems packaging. - For RHEL, you can use [1] as an example and optionally comment on Bug 788001 to push these macros into RHEL * Documentation in -doc subpackage - Have you considered to put the documentation into -doc subpackage? It is typically substantial part of the rubygem- package payload. * mongo dependencies - You were requested to remove the rubygem(mongo) dependency. However, the .gemspec still requires the dependency. This should be fixed upstream and temporary patched in .gemspec # irb irb(main):001:0> require 'stickshift-common' Gem::LoadError: Could not find mongo (>= 0) amongst [activemodel-3.2.7, activesupport-3.2.7, bigdecimal-1.1.0, builder-3.0.0, i18n-0.6.0, io-console-0.3, json-1.6.5, multi_json-1.3.6, openshift-origin-common-0.13.3, rdoc-3.12] from /usr/share/rubygems/rubygems/dependency.rb:247:in `to_specs' from /usr/share/rubygems/rubygems/specification.rb:777:in `block in activate_dependencies' from /usr/share/rubygems/rubygems/specification.rb:766:in `each' from /usr/share/rubygems/rubygems/specification.rb:766:in `activate_dependencies' from /usr/share/rubygems/rubygems/specification.rb:750:in `activate' from /usr/share/rubygems/rubygems.rb:212:in `rescue in try_activate' from /usr/share/rubygems/rubygems.rb:209:in `try_activate' from /usr/share/rubygems/rubygems/custom_require.rb:59:in `rescue in require' from /usr/share/rubygems/rubygems/custom_require.rb:35:in `require' from (irb):1 from /usr/bin/irb:12:in `<main>' * Url does not correspondent with the gems one - URL in .spec says openshift.redhat.com while the .gemspec contains line s.homepage = "http://www.openshift.com";. These two should be aligned IMO * Is Requires: policycoreutils-python needed? - The selinux-policy owns the /usr/share/selinux/packages/ directory, but what is the need to require policycoreutils-python? BTW I am not sure why the line 'require "stickshift-common/exceptions/ss_exception"' is duplicated in lib/stickshift-common.rb, but this is upstream issue. [1] http://pkgs.fedoraproject.org/cgit/rubygem-hydra.git/tree/rubygem-hydra.spec -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review