[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=846913

--- Comment #9 from Matěj Cepl <mcepl@xxxxxxxxxx> ---
(In reply to comment #2)
> There was different error in koji than the one you have pasted here. I've
> fixed this error, but I'm not sure how to fix the one you've pasted in your
> Comment 1.
> 
> Those two files are built only when Qt > 4.7. Is it somehow possible to
> check that in spec file? I haven't found solution yet.

I am not sure what's the problem, but it seems to me that

%if 0%{?rhel}
BuildRequires:  qt4-devel
%else
BuildRequires:  qt-devel
%endif

is a bit too simple. Usually people want to check for particular versions of
the distro ... my EL-7 has probably something else installed than EL-6 in koji.
I ended up in spectrum.spec with constructs like

%if 0%{?rhel} > 0 && 0%{?rhel} <= 5

or perhaps (that's from bitlbee)

%if 0%{?fedora} >= 15 || 0%{?rhel} >= 7

or something of that sort. You have to know best what exact packages you need.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]