[Bug 827101] Review Request: trayer-srg - a small gtk2 systray

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=827101

--- Comment #7 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4371101

$ rpmlint -i -v *
trayer-srg.i686: I: checking
trayer-srg.i686: W: spelling-error Summary(en_US) systray -> stray
The value of this tag appears to be misspelled. Please double-check.

trayer-srg.i686: W: spelling-error %description -l en_US systray -> stray
The value of this tag appears to be misspelled. Please double-check.

trayer-srg.i686: W: no-url-tag
The URL tag is missing.

trayer-srg.i686: W: file-not-utf8 /usr/share/doc/trayer-srg-1.1/CREDITS
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

trayer-srg.i686: W: no-manual-page-for-binary trayer
Each executable in standard binary directories should have a man page.

trayer-srg.src: I: checking
trayer-srg.src: W: spelling-error Summary(en_US) systray -> stray
The value of this tag appears to be misspelled. Please double-check.

trayer-srg.src: W: spelling-error %description -l en_US systray -> stray
The value of this tag appears to be misspelled. Please double-check.

trayer-srg.src: W: no-url-tag
The URL tag is missing.

trayer-srg.src: I: checking-url
https://github.com/bryanbickford/trayer/blob/master/trayer-srg-1.1-1.tar.gz
(timeout 10 seconds)
trayer-srg.src: W: file-size-mismatch trayer-srg-1.1-1.tar.gz = 27200,
https://github.com/bryanbickford/trayer/blob/master/trayer-srg-1.1-1.tar.gz =
28344
The size of the file in the package does not match the size indicated by
peeking at its URL.  Verify that the file in the package has the intended
contents.

trayer-srg.x86_64: I: checking
trayer-srg.x86_64: W: spelling-error Summary(en_US) systray -> stray
The value of this tag appears to be misspelled. Please double-check.

trayer-srg.x86_64: W: spelling-error %description -l en_US systray -> stray
The value of this tag appears to be misspelled. Please double-check.

trayer-srg.x86_64: W: no-url-tag
The URL tag is missing.

trayer-srg.x86_64: W: file-not-utf8 /usr/share/doc/trayer-srg-1.1/CREDITS
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

trayer-srg.x86_64: W: no-manual-page-for-binary trayer
Each executable in standard binary directories should have a man page.

trayer-srg-debuginfo.i686: I: checking
trayer-srg-debuginfo.i686: W: no-url-tag
The URL tag is missing.

trayer-srg-debuginfo.i686: E: empty-debuginfo-package
This debuginfo package contains no files.  This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else.  Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.

trayer-srg-debuginfo.x86_64: I: checking
trayer-srg-debuginfo.x86_64: W: no-url-tag
The URL tag is missing.

trayer-srg-debuginfo.x86_64: E: empty-debuginfo-package
This debuginfo package contains no files.  This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else.  Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.

5 packages and 0 specfiles checked; 2 errors, 16 warnings.



Please add an URL: tag to your spec.


The file "CREDITS" has a bad character encoding, append the following commands
to the %prep section:

iconv -f iso-8859-15 -t utf8 CREDITS > CREDITS.new
touch -r CREDITS CREDITS.new
mv CREDITS.new CREDITS


The debug package is empty. This happens because binaries have been stripped
before creating the debug info. You tried to fix this with the CFLAGS variable
in the make call, but the Makefile doesn't contain CFLAGS, that's why nothing
happens. Normally the Makefile.common should be recognized, which defines
CFLAGS, but it isn't.


In contrast to INSTALL, there's no configure script which can be run. We have
to use the Makefile anyway. You should inform the upstream developers about
this. In any case, the Makefile has to be changed to reflect the good CFLAGS
variable. In general, the Makefile needs some tweaking:

TARGET = trayer

This should be trayer-srg, because we speak about a fork of trayer, not about
trayer itself.


The sources contain a manpage (with the name trayer instead of trayer-srg
again). This is not installed. Fix the application name in trayer.1, rename it
to trayer-srg and install it with the following command:

install -D -p -m 644 man/%{name}.1 $RPM_BUILD_ROOT/%{_mandir}/man1/%{name}.1

Add the following line to %files:
%{_mandir}/man1/%{name}.1.*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]