https://bugzilla.redhat.com/show_bug.cgi?id=845799 --- Comment #3 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- Updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-hashr/rubygem-hashr.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-hashr/rubygem-hashr-0.0.21-2.fc17.src.rpm Fixed: * Use %global instead of %define * Test suite * License * -doc subpackage * Please use the new RubyGems packaging macros ad /Please consider to use "%if 0%{?el6}%{?fc16}" macros instead of wordy "%if 0%{?rhel} == 6 || 0%{?fedora} < 17"/ I do not like the shorter notation. It is less readable and thefore maintainable (of course IMHO). And while 0%{?fedora} < 17 works for Fedora 15, shorter notation %{?fc16}. I know that F15 is not supported, but still.. I simply like the longer notation. * Exclude gemcache per our IRC discussion I will keep it here. I like the sideefect of repackaging, where - in case package will get patch - the repackage gem contains those patch(es) and developers, which develop for Fedora on their macs, can use this gem, which contains these patch(es). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review