https://bugzilla.redhat.com/show_bug.cgi?id=845799 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Use %global instead of %define - Unless there is any special need, the %global macro should be used in place of %define according to FPG [1] * Test suite - It would be nice to execute a test suite of the gem. * License - According to README.md and MIT-LICENSE files, the license should be MIT * -doc subpackage - Have you considered to move the documentation into -doc subpackage? * Please use the new RubyGems packaging macros [2] - It would be nice to use the macros available for gem packaging. - For RHEL, you can use [3] as an example and optionally comment on Bug 788001 to push these macros into RHEL ;) * RHEL and older Fedora release conditioning - Please consider to use "%if 0%{?el6}%{?fc16}" macros instead of wordy "%if 0%{?rhel} == 6 || 0%{?fedora} < 17" * Exclude gemcache - We typically exclude the cached version of gem, such as: %exclude %{gem_cache} I would stop at this point and wait for fixes from your side. Thank you. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define [2] https://fedoraproject.org/wiki/Packaging:Ruby#Macros [3] http://pkgs.fedoraproject.org/cgit/rubygem-hydra.git/tree/rubygem-hydra.spec -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review