[Bug 843767] Review Request: python-pandas - Python library providing high-performance data analysis tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=843767

--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ koji build for f17 is successful ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=4344489

+ rpmlint on rpms gave
python-pandas.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/pandas/_period.so _period.so()(64bit)
python-pandas.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/pandas/lib.so lib.so()(64bit)
python-pandas.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/pandas/_sparse.so _sparse.so()(64bit)
python-pandas.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/pandas/_algos.so _algos.so()(64bit)
python-pandas.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/pandas/setup.py 0644L /usr/bin/env
2 packages and 0 specfiles checked; 1 errors, 4 warnings.

+ Source verified with upstream as (sha1sum)
f54ccf3d28a6b3dff1c7d771f6a3b542e1767051  pandas-0.8.1.tar.gz
f54ccf3d28a6b3dff1c7d771f6a3b542e1767051  ../SOURCES/pandas-0.8.1.tar.gz

+ License is BSD.


suggestions:
1) Replace %define with %global

2) If package is only for Fedora then you can remove buildroot, cleaning of
buildroot in %install, %clean section and defattr(-,root,root,-)

3) Add README.rst LICENSE to %docs

4) run tests using

%check
PYTHONPATH=`pwd`/build/lib.linux-x86_64-2.7/ python pandas/tests/test_index.py

5) Add following to silent the rpmlint private-shared-object-provides messages

%{?filter_setup:
%filter_provides_in %{python_sitearch}.*\.so$
%filter_setup
}

6) also fix other rpmlint error non-executable-script

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]