https://bugzilla.redhat.com/show_bug.cgi?id=844325 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review:- + mock build for f17 is successful. + rpmlint on rpms gave python-rpi-gpio.src: I: checking python-rpi-gpio.src: I: checking-url http://code.google.com/p/raspberry-gpio-python/ (timeout 10 seconds) python-rpi-gpio.src: I: checking-url http://pypi.python.org/packages/source/R/RPi.GPIO/RPi.GPIO-0.3.1a.tar.gz (timeout 10 seconds) python-rpi-gpio.x86_64: I: checking python-rpi-gpio.x86_64: I: checking-url http://code.google.com/p/raspberry-gpio-python/ (timeout 10 seconds) 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha1sum) f1aa44f1c8bd602b203a08057879950a89afdef7 RPi.GPIO-0.3.1a.tar.gz f1aa44f1c8bd602b203a08057879950a89afdef7 ../SOURCES/RPi.GPIO-0.3.1a.tar.gz + License is MIT. suggestions: 1) Replace %define with %global 2) If package is only for Fedora then you can remove buildroot, cleaning of buildroot in %install, %clean section and defattr(-,root,root,-) 3) following comment does not makes any sense as there is no reference patch/source associated with it. #Updated address, patch sent to the upstream on 15/05/2012 APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review