https://bugzilla.redhat.com/show_bug.cgi?id=834802 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> --- A few findings: License is GPLv3+. licensecheck reveals it. The spec-file must be called %{name}. It does not contain a version number and the capitalization must be the same as in %{name}. Please see http://fedoraproject.org/wiki/Packaging:NamingGuidelines. Version requirements are often not necessary. Also use the name macro where it makes sense. Don't Require libraries. Refer to http://fedoraproject.org/wiki/Packaging:Guidelines#Requires. Don't install static libraries, see http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries. Delete defattr and all EPEL specialities, i. e.: clean section, rm in the install section. Using desktop-file-install is enough -- you don't need to run desktop-file-validate as well. Consider to ship TODO and ChangeLog as documentation as well. You must not own %{_datadir}/locale. What are gir and %{_libdir}/girepository-1.0/RhythmCatLib-2.0.typelib? %dir %{_datadir}/gtk-doc/html/LibRhythmCat-%{version} is not necessary, as you already own the directory by the previous statement. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review