[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844080

--- Comment #9 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> ---
(In reply to comment #8)
> (In reply to comment #7)
> > sucessful scratch build with official release package
> > 
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=4340166
> 
> What means "official release package"? Where do you've got this from?

http://pub.mate-desktop.org/releases/1.4/libmatecomponent-1.4.0.tar.xz

> Too many BuildRequires again:
> 
> BuildRequires: 	libxml2-devel >= %{libxml2_version}
> BuildRequires: 	mate-corba-devel >= %{mate_corba_version}
> BuildRequires: 	intltool >= 0.14-1
> BuildRequires: 	automake autoconf libtool
> BuildRequires: 	gtk-doc
> BuildRequires: 	flex, bison, zlib-devel, popt-devel
> BuildRequires: 	dbus-glib-devel
> BuildRequires: 	gettext
> BuildRequires:  mate-common
> 
> To drop:
> 
> gettext (needed by intltool)
> autoconf (needed by automake)
> automake (needed by mate-corba-devel)
> 
> 
> 
> $ rpmlint -i -v *
> ...
> libmatecomponent.i686: W: summary-not-capitalized C libmate component system
> Summary doesn't begin with a capital letter.
> ...
> libmatecomponent.i686: W: conffile-without-noreplace-flag
> /etc/matecomponent-activation/matecomponent-activation-config.xml
> A configuration file is stored in your package without the noreplace flag. A
> way to resolve this is to put the following in your SPEC file:
> %config(noreplace) /etc/your_config_file_here
> 
> libmatecomponent.i686: E: incorrect-fsf-address
> /usr/share/doc/libmatecomponent-1.4.0/COPYING
> The Free Software Foundation address in this file seems to be outdated or
> misspelled.  Ask upstream to update the address, or if this is a license
> file,
> possibly the entire file with a new copy available from the FSF.
> 
> libmatecomponent.i686: W: no-manual-page-for-binary matecomponent-slay
> Each executable in standard binary directories should have a man page.
> ...
> libmatecomponent.src:68: E: hardcoded-library-path in
> %{_prefix}/lib/matecomponent/servers
> A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
> should be replaced by something like /%{_lib} or %{_libdir}.
> ...
> libmatecomponent.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4,
> tab: line 4)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic
> annoyance.  Use either spaces or tabs for indentation, not both.
> ...
> libmatecomponent.x86_64: E: incorrect-fsf-address
> /usr/share/doc/libmatecomponent-1.4.0/COPYING
> The Free Software Foundation address in this file seems to be outdated or
> misspelled.  Ask upstream to update the address, or if this is a license
> file,
> possibly the entire file with a new copy available from the FSF.
> ...
> 7 packages and 0 specfiles checked; 41 errors, 19 warnings.
> 
> 
> Not the whole output, interesting stuff only. All this has to be handled
> before we can speak about "Ready for review".

I know, i did this quick scratch build only for showing
that building with current upstream from mate works.

But, thanks for your hints i will check it later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]