https://bugzilla.redhat.com/show_bug.cgi?id=844015 --- Comment #11 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- (In reply to comment #10) > Hi Wolfgang, > > Thanks for taking the time to help contribute to the work going in to MATE > Desktop for Fedora. > > Some initial thoughts: > > Easy stuff: > > 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in > source folder) This is a must > 2) Please remove source1 This is allowed (show me the guideline that prohibits this) > 3) Please update URL to http://mate-desktop.org This is a must. > 4) Please remove specific versions from dependencies (see below). This is allowed and needed. (show me the guideline that prohibits this) > 5) Please remove unneeded defines in top of spec file. This is a must. Change %defines to %global > 6) Please remove patches and submit them to upstream, or give a logical > explanation of why they MUST be in this package. This is allowed. (show me the guideline that prohibits this) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review