https://bugzilla.redhat.com/show_bug.cgi?id=844015 --- Comment #10 from Dan Mashal <dan.mashal@xxxxxxxxx> --- Hi Wolfgang, Thanks for taking the time to help contribute to the work going in to MATE Desktop for Fedora. Some initial thoughts: Easy stuff: 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in source folder) 2) Please remove source1 3) Please update URL to http://mate-desktop.org 4) Please remove specific versions from dependencies (see below). 5) Please remove unneeded defines in top of spec file. 6) Please remove patches and submit them to upstream, or give a logical explanation of why they MUST be in this package. Specific versions in the spec file because are not necessary. I understand you are looking out for the users in your repo but that is the reason why we stopped pushing packages to the repo and are building on rawhide only for now. ============================================================================ tail of fedora-review build.log: INFO: Installed packages: Start: build phase for mate-conf-1.4.0-7.fc18.src.rpm Start: device setup Finish: device setup Start: build setup for mate-conf-1.4.0-7.fc18.src.rpm ERROR: Exception(/home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-7.fc18.src.rpm) Config(fedora-17-x86_64) 0 minutes 11 seconds INFO: Results and/or logs in: /home/dan/844015-mate-conf/results ERROR: Command failed: # ['/usr/bin/yum-builddep', '--installroot', '/var/lib/mock/fedora-17-x86_64/root/', '/var/lib/mock/fedora-17-x86_64/root///builddir/build/SRPMS/mate-conf-1.4.0-7.fc17.src.rpm'] Getting requirements for mate-conf-1.4.0-7.fc17.src --> libxml2-devel-2.7.8-7.fc17.x86_64 --> libxslt-devel-1.1.26-9.fc17.x86_64 Error: No Package found for mate-corba-devel >= 1.1.0 ================================================================================ rmlint on srpm: $ rpmlint mate-conf-1.4.0-7.fc18.src.rpm mate-conf.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged mate-conf.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands mate-conf.src: W: spelling-error %description -l en_US workgroup -> work group, work-group, groundwork mate-conf.src:113: W: deprecated-grep [u'fgrep'] mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 7) 1 packages and 0 specfiles checked; 0 errors, 5 warnings. MUST fix: mate-conf.src:113: W: deprecated-grep [u'fgrep'] mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 7) ================================================================================ Also we don't need to create a separate gtk package for files that are already provided by gnome in the Fedora stable repo (unless we have a VERY good reason). Please also run rpmlint on the binary rpm generated on my local machine there are a few files that used rpath (I'm still working on it but you can see my spec file on my fp page that is a WIP). Please review the following: https://fedoraproject.org/wiki/Common_Rpmlint_issues http://fedoraproject.org/wiki/Packaging:Guidelines Please also keep in mind, we want to package an RPM that is as close to upstream source as possible with as little modification to the source code as possible. We do not want to modify or patch the code whatsoever unless absolutely necessary. If there is something that you disagree with, please talk to me on IRC or google talk and we can discuss it further. Once you address all of the issues above the package review can continue. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review