[Bug 842509] Review Request: libdbusmenu - A helper library for libindicator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=842509

--- Comment #7 from Michael Scherer <misc@xxxxxxxx> ---
The explicit requires on gtk3 is IMHO unwarranted, since rpm already detect it
fine.

I also do not see why the main rpm requires vala, since that's a run time
library.

The same goes for gobject-introspection, who is pulled twice by -devel ( one
time explicitely, one time by the main rpm pulled by -devel ).

The Requires pkgconfig is already detected on newer rpm ( ie > EL 5 ), so can
be dropped. ( like rm -rf $RPM_BUILD_ROOT in %install, btw ).


The multiple license of the tarbal requires more comments (
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
)

And are the ldconfig call still needed ? ( real question, i think they were
taken care by some automated script nowadays but maybe I am just dreaming )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]