https://bugzilla.redhat.com/show_bug.cgi?id=840707 --- Comment #62 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- I am busy and wont be able to re-review the new spec and srpm till the Thursday/Friday. If you had made the changes I recommended I could have completed the review sooner, but you insisted on making more changes. I really don't see the need for the devel sub-package for 1 poxy file when gnome-doc-utils didn't. [root@main-pc results]# rpm -qf /usr/share/pkgconfig/gnome-doc-utils.pc gnome-doc-utils-0.20.10-2.fc17.noarch In fact there seems to be a reason behind it, so revert the changes you made i.e get rid of the devel sub-package. https://bugzilla.redhat.com/show_bug.cgi?id=629647 You also need to add obsoletes and provides as Wolfgang suggested.(In reply to comment #58) > (In reply to comment #57) > > (In reply to comment #56) > > > > > And why add a subpackage for stylsheets ? ( "gnome does this way" is not a > > > reason, that's just cargo cult programming, and while there is surely a good > > > reason, I think it should be know and see if this is still valid ) > > > > > > There is also some notes from comment 11, like %clean and %defattr no longer > > > needed. > > > > > > > without this subpackage a lot of users from my repo will prevent from > > updating > > see Comment 45 > > Do you want this? > > There are mechanisms to Obselete packages, one quick example can be the > usage of a Obsoletes/Provides duet, example: > > * mate-doc-utils: > > (...) > Obsoletes: mate-doc-utils-stylesheets < %{version} > Provides: mate-doc-utils-stylesheets = %{version} > (...) > > This will allow users to update; the mate-doc-utils-stylesheets will get > obsoleted and uninstalled. After a few releases when you believe all users > have updated you can pretty much remove the Obsoletes/Provides duet. > > This is probably the best way to Obsolete a Package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review