[Bug 840707] Review Request: mate-doc-utils -- mate doc utils

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=840707

--- Comment #12 from raveit65 <chat-to-me@xxxxxxxxx> ---
Several things:
1. Why do you use the export python path after configure?
I do not use it it my spec files, it's also not in
http://koji.fedoraproject.org/koji/buildinfo?buildID=197226 from M. Classens
spec file from gnome-doc-utils, where my spec file is based.


2. Do not use a configure flag with autogen.sh, it makes no sence if you use
configure after it. Better

NOCONFIGURE=1 ./autogen.sh

%build
%configure --disable-scrollkeeper --enable-build-utils
make

3. We have conflicting files with gnome-doc-utils, see
https://github.com/mate-desktop/mate-doc-utils/issues/2
I have solved this in this way:
After make install in the %install section

rm -f $RPM_BUILD_ROOT%{_datadir}/xml/mallard/1.0/mallard.rnc
rm -f $RPM_BUILD_ROOT%{_datadir}/xml/mallard/1.0/mallard.rng
rm -f $RPM_BUILD_ROOT%{_datadir}/pkgconfig/xml2po.pc
rm -rf $RPM_BUILD_ROOT%{_datadir}/man
rm -f $RPM_BUILD_ROOT%{_bindir}/xml2po

and add gnome-doc-utils as requires.
The idea is using files from gnome-doc-utis for mate-doc-utils.
This works perfect.


4. Give me and the users of my repo a favor and split the package in 2,
otherwise we get problem with updating my packages.
(gnome-doc-utils is split in the same way). After describtion!

# note that this is an "inverse dependency" subpackage
%package stylesheets
Summary: XSL stylesheets used by mate-doc-utils
License: LGPLv2+
Group: Development/Tools
# for /usr/share/pkgconfig
Requires: pkgconfig
# for /usr/share/xml
Requires: xml-common
Requires: gnome-doc-utils-stylesheets

and

%find_lang %{name}

%files -f %{name}.lang
%defattr(-,root,root,-)
%doc AUTHORS README NEWS COPYING COPYING.GPL COPYING.LGPL
%{_bindir}/*
%{_datadir}/pkgconfig/mate-doc-utils.pc
%{_datadir}/aclocal/mate-doc-utils.m4
%{_datadir}/mate/help/mate-doc-make
%{_datadir}/mate/help/mate-doc-xslt
%{_datadir}/omf/mate-doc-make
%{_datadir}/omf/mate-doc-xslt
%{_datadir}/mate-doc-utils
#%doc %{_mandir}/man1/xml2po.1.gz
#%{python_sitelib}/xml2po/

%files stylesheets
%defattr(-,root,root,-)
#%{_datadir}/pkgconfig/xml2po.pc
%{_datadir}/xml/mate
#%{_datadir}/xml/mallard

Here you see i've comment out the conflicting files (point 3).

Another way is to obsolete mate-doc-utils-stylesheets.


5. mate-common you need only as BuildRequires: not as Requires.
>From my spec files

### Dependencies ###

Requires: libxml2 >= 2.6.12
Requires: libxslt >= 1.1.8
Requires: libxml2-python
# for /usr/share/aclocal
Requires: automake
# for /usr/share/mate/help
Requires: mate-doc-utils-stylesheets = %{version}-%{release}
Requires: gnome-doc-utils

### Build Dependencies ###

BuildRequires: libxml2-devel >= 2.6.12
BuildRequires: libxslt-devel >= 1.1.8
BuildRequires: libxml2-python

BuildRequires: intltool
BuildRequires: gettext
BuildRequires: scrollkeeper
BuildRequires: rarian-devel
BuildRequires: mate-common


@ Michael Scherer
I know this error, but it exists only with mock and effected several mate
packages. It seems to be that mock load some information from outside with a
network connection.
But i had no solution exept this QUICK&DIRTY
I disable the network connection after mock has download the build requires.
I know this is not a solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]