https://bugzilla.redhat.com/show_bug.cgi?id=840707 --- Comment #11 from Michael Scherer <misc@xxxxxxxx> --- Anyway, a few note : - why do you add /usr/local/lib/... to the PYTHONPATH ? this should not be needed since no rpm should store anything there. It that affect the runtime env, then I think a comment should be added to explain. - %clean is not needed, so does %defattr(-,root,root,-) ( default settings of rpm since a few years ) ( https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean ) - python_sitelib is already define in rpm on all supported Fedora version, if I am not wrong, so maybe this part can be skipped https://fedoraproject.org/wiki/Packaging:Python#Macros - BuildRequires are easier to read if there is one per line, since this produce better diff output, and ease review of patches - Directory %{_datadir}/mate/ is unowned as well as%{_datadir}/mate-doc-utils/ https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership - I didn't look closely, but the lack of python-devel is suspicious. There should be a explicit version of python to prepare migration to python 3, but I am not sure how. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review