https://bugzilla.redhat.com/show_bug.cgi?id=841335 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Final look: $ rpmlint gnusim8085-1.3.7-2.fc17.x86_64.rpm gnusim8085.x86_64: W: spurious-executable-perm /usr/share/doc/gnusim8085-1.3.7/COPYING Ha, that's what happens when one touches packages. :-) $ rpmls -p gnusim8085-1.3.7-2.fc17.x86_64.rpm lists a directory that doesn't contain any files (have missed that before): /usr/share/pixmaps/gnusim8085 > -URL: http://gnusim8085.org/ > +URL: http://www.gnusim8085.org/ Maybe, maybe not. ;) The latter here redirects to http://gnusim8085.org/ > -%{_datadir}/doc/%{name}* > +%{_datadir}/doc/%{name}-%{version}/* https://fedoraproject.org/wiki/Packaging:UnownedDirectories => %{_datadir}/doc/%{name}-%{version}/ As a second thought, a little bit safer than that path for the doc files would be %configure --docdir %{_datadir}/doc/%{name} and %{_datadir}/doc/%{name}/ in the files list. That path doesn't conflict with using %doc to add files. However, if any %doc files were to be added manually, you would end up with two doc directories, %{_datadir}/doc/%{name} and %{_datadir}/doc/%{name}-%{version}, so that would be a different pitfall. Adding a comment that using %doc to add files manually bears a risk could be helpful, too. No minor update needed for this review. These are small issues you can fix more conveniently within Fedora package git. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review