Bug 225822: Merge Review: gnome-media Product: Fedora Extras Version: devel Component: Package Review Deji Akingunola <dakingun@xxxxxxxxx> has denied Deji Akingunola <dakingun@xxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225822 ------- Additional Comments from Deji Akingunola <dakingun@xxxxxxxxx> A couple of issues for gnome-media; NEEDSWORK: * rpmlint (on the binary package, the -devel subpackage, and the srpm) produces a number of warnings/errors. Most of it can possibly be ignored, but I think the rpath issue need to be fixed >> [deji@agape reviews]$ rpmlint gnome-media-2.17.90-1.fc7.x86_64.rpm E: gnome-media tag-not-utf8 %changelog E: gnome-media obsolete-not-provided gnome E: gnome-media binary-or-shlib-defines-rpath /usr/lib64/libglade/2.0/libgnome-media-profiles.so ['/usr/lib64'] E: gnome-media binary-or-shlib-defines-rpath /usr/bin/gnome-audio-profiles-properties ['/usr/lib64'] E: gnome-media binary-or-shlib-defines-rpath /usr/bin/gnome-cd ['/usr/lib64'] E: gnome-media binary-or-shlib-defines-rpath /usr/libexec/cddb-track-editor ['/usr/lib64'] W: gnome-media non-conffile-in-etc /etc/gconf/schemas/CDDB-Slave2.schemas W: gnome-media non-conffile-in-etc /etc/gconf/schemas/gnome-audio-profiles.schemas W: gnome-media non-conffile-in-etc /etc/gconf/schemas/gnome-volume-control.schemas W: gnome-media non-conffile-in-etc /etc/gconf/schemas/gnome-cd.schemas [deji@agape reviews]$ rpmlint gnome-media-devel-2.17.90-1.fc7.x86_64.rpm E: gnome-media-devel tag-not-utf8 %changelog W: gnome-media-devel no-documentation [deji@agape reviews]$ rpmlint gnome-media-2.17.90-1.fc7.src.rpm E: gnome-media tag-not-utf8 %changelog E: gnome-media non-utf8-spec-file gnome-media.spec W: gnome-media unversioned-explicit-obsoletes gnome W: gnome-media macro-in-%changelog _datadir W: gnome-media mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 22) * scrollkeeper-update is not being properly called in the post and postun sections according to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect= ScriptletSnippets#head-a4ea5e1946bc113d19d24b4f5bfb543c579e5fc8 * "--add-category X-Redhat-Base" option to desktop-file-install is no longer necesary Not so importantly, the "disable-schemas-install" option can be pass to the configure script instead of setting and unsetting GCONF_DISABLE_MAKEFILE_SCHEMA_INSTAL env. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review