Bug 225838: Merge Review: gnome-system-monitor Product: Fedora Extras Version: devel Component: Package Review Deji Akingunola <dakingun@xxxxxxxxx> has denied Deji Akingunola <dakingun@xxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225838 ------- Additional Comments from Deji Akingunola <dakingun@xxxxxxxxx> Good: * Package name conforms to the Fedora Naming Guidelines * Sources, Group and License tags properly in place * Locales handled correctly * All necessary BuildRequires listed. * Package builds OK in Mock. NEEDSWORK: According to the packaging guildlines on rpm scriplets, * The post and postun Requires on desktop-file-utils is not necessary * call to scrollkeeper-update in post section is inclomplete, should be called like; "scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :" * I believe the "add-category X-Redhat-Base" is no longer necessary for the desktop file install. A couple of other minor nitpicks; * You can pass the "--disable-schemas-install" option to the configure script, without needing to set and unset the GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL env. * There are a number of rpmlint warnings/errors which I believe can be ignored; [deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.src.rpm W: gnome-system-monitor unversioned-explicit-obsoletes gtop [deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.x86_64.rpm E: gnome-system-monitor obsolete-not-provided gtop W: gnome-system-monitor no-documentation W: gnome-system-monitor non-conffile-in-etc /etc/gconf/schemas/gnome-system-monitor.schemas _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review