https://bugzilla.redhat.com/show_bug.cgi?id=834127 --- Comment #17 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/VirtualGL/libdlfaker.so VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/VirtualGL/libgefaker.so VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/VirtualGL/librrfaker.so VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/fakelib/libGL.so These are okay. ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [X]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Assuming the removing of bundling is okay, this is all set. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt rpms [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. I added blank lines between entries... [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Package requires other packages for directories it uses. I fixed owning %{_libdir}/VirtualGL/ [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Package complies to the Packaging Guidelines [!]: MUST Spec file lacks Packager, Vendor, PreReq tags. Note: Found : Vendor: The VirtualGL Project [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Checking original sources for licenses Licenses found: "LGPL (v2 or later)", "LGPL (v2 or later) GENERATED FILE", "*No copyright* UNKNOWN", "UNKNOWN", "*No copyright* Public domain", "MIT/X11 (BSD like)" For detailed output of licensecheck see file: /export/home/orion/redhat/VirtualGL-2.3.1/VirtualGL/licensecheck.txt [x]: MUST License file installed when any subpackage combination is installed. [ ]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. Note: Using prebuilt rpms [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SHOULD Scriptlets must be sane, if used. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: http://downloads.sourceforge.net/project/virtualgl/VirtualGL/%{version}/VirtualGL-%{version}.tar.gz (VirtualGL-%{version}.tar.gz) Patch0: VirtualGL-2.3.1-redhatpathsfix.patch (VirtualGL-2.3.1-redhatpathsfix.patch) Patch1: VirtualGL-fltk.patch (VirtualGL-fltk.patch) Patch2: VirtualGL-glx.patch (VirtualGL-glx.patch) I don't like using %{name} for patches. Up to you for this. [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Spec file lacks Packager, Vendor, PreReq tags. Note: Found : Vendor: The VirtualGL Project This needs to get removed. [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text This is okay, license is installed in %docdir. [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/VirtualGL/libdlfaker.so VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/VirtualGL/libgefaker.so VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/VirtualGL/librrfaker.so VirtualGL-2.3.1-2.fc17.i686.rpm : /usr/lib/fakelib/libGL.so See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages False positive, these are okay. Rpmlint ------- Checking: VirtualGL-2.3.1-2.fc17.i686.rpm VirtualGL-2.3.1-3.fc17.src.rpm VirtualGL-debuginfo-2.3.1-2.fc17.i686.rpm VirtualGL.i686: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing VirtualGL.i686: W: no-manual-page-for-binary vglconfig VirtualGL.i686: W: no-manual-page-for-binary nettest VirtualGL.i686: W: no-manual-page-for-binary vglrun VirtualGL.i686: W: no-manual-page-for-binary glxspheres VirtualGL.i686: W: no-manual-page-for-binary vglclient VirtualGL.i686: W: no-manual-page-for-binary vgllogin VirtualGL.i686: W: no-manual-page-for-binary vglxinfo VirtualGL.i686: W: no-manual-page-for-binary cpustat VirtualGL.i686: W: no-manual-page-for-binary vglgenkey VirtualGL.i686: W: no-manual-page-for-binary vglserver_config VirtualGL.i686: W: no-manual-page-for-binary tcbench VirtualGL.i686: W: no-manual-page-for-binary vglconnect VirtualGL.src: W: spelling-error %description -l en_US vglrun VirtualGL.src: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing VirtualGL.src: W: spelling-error %description -l en_US vglclient -> clientele 3 packages and 0 specfiles checked; 0 errors, 16 warnings. Requires -------- VirtualGL-2.3.1-2.fc17.i686.rpm (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig libGL.so.1 libGLU.so.1 libX11.so.6 libXext.so.6 libXv.so.1 libc.so.6 libcrypto.so.10 libdl.so.2 libm.so.6 libpthread.so.0 libssl.so.10 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libturbojpeg.so libturbojpeg.so(TURBOJPEG_1.0) libturbojpeg.so(TURBOJPEG_1.1) rtld(GNU_HASH) VirtualGL-debuginfo-2.3.1-2.fc17.i686.rpm (rpmlib, GLIBC filtered): Provides -------- VirtualGL-2.3.1-2.fc17.i686.rpm: VirtualGL = 2.3.1-2.fc17 VirtualGL(x86-32) = 2.3.1-2.fc17 libdlfaker.so libgefaker.so librrfaker.so VirtualGL-debuginfo-2.3.1-2.fc17.i686.rpm: VirtualGL-debuginfo = 2.3.1-2.fc17 VirtualGL-debuginfo(x86-32) = 2.3.1-2.fc17 MD5-sum check ------------- /export/home/orion/redhat/VirtualGL-2.3.1/VirtualGL/upstream/VirtualGL-2.3.1.tar.gz : MD5SUM this package : 6c7dcfce0541df7f5bd8a07d4c480fb1 MD5SUM upstream package : 6c7dcfce0541df7f5bd8a07d4c480fb1 Generated by fedora-review 0.2.0git External plugins: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review