Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: kdelibs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225963 rdieter@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO AssignedTo|rdieter@xxxxxxxxxxxx |than@xxxxxxxxxx Flag|fedora-review? |needinfo?(rdieter@xxxxxxxxxx | |du), fedora-review- ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-02-07 12:53 EST ------- On first glance (otherwise, looking good): * SHOULD omit Requires: cups ... Obsoletes: %{name}2 Obsoletes: kdesupport Obsoletes: kdoc that's all ancient history, no need, imo, to carry the baggage anymore. * -devel pkg SHOULD Requires: qt-devel unversioned here is ok, main pkg already includes Requires: qt >= EVR omit legacy crud: Obsoletes: kdesupport-devel * SHOULD omit Requires(pre,post): desktop-file-utils per http://fedoraproject.org/wiki/Packaging/ScriptletSnippets it is no longer required (FC-5+) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review